oh-my-bash icon indicating copy to clipboard operation
oh-my-bash copied to clipboard
verified publisher icon ohmybash

[Plugin] adding starship

Open Heus-Sueh opened this issue 1 year ago • 3 comments

close my own issue: https://github.com/ohmybash/oh-my-bash/issues/627

I believe I didn't do anything wrong in the code

Heus-Sueh avatar Oct 14 '24 15:10 Heus-Sueh

starship conflicts with a theme specified by OSH_THEME since both provide PS1. Shouldn't this be implemented as a theme?

akinomyoga avatar Oct 14 '24 17:10 akinomyoga

In addition, our themes are supposed to be able to switch to another theme when requested, i.e. a theme can be unloaded and another theme can be loaded. Starship can be enabled by eval "$(starship init bash)", but is there a way to unload Starship in a Bash session where Starship was loaded?

akinomyoga avatar Oct 14 '24 17:10 akinomyoga

starship conflicts with a theme specified by OSH_THEME since both provide PS1. Shouldn't this be implemented as a theme?

I based it on what ohmyzsh did, which is a plugin instead of a conventional theme

but is there a way to unload Starship in a Bash session where Starship was loaded?

Looking at the starship commands, I didn't find a way to turn it off in an active session

maybe I should add this giant warning:

⚠️ ENABLING THIS PLUGIN WILL UNSET YOUR OSH_THEME VARIABLE

?

Heus-Sueh avatar Oct 14 '24 18:10 Heus-Sueh

Although providing an external theme through a "plugin" instead of a "theme" seems wrong, it should probably better for the consistency with the upstream Oh My Zsh.

akinomyoga avatar Nov 14 '24 03:11 akinomyoga