oh-my-bash
oh-my-bash copied to clipboard
ohmybash
themes/pzq: Add pzq themes inspired by ys-theme from oh-my-zsh and rana
- Add pzq theme, which is inspired on ys-theme from oh-my-zsh and rana theme
- The pzq theme solves the problem of misplaced commands in rena
@chaifeng @MichaelAnckaert @matjam Can you please help me review this commit and give some comments?
@matjam
there's inconsistent indenting throughout this PR
Thanks for pointing that for me! This is really a mistake and I think I have solved it.
looks like it's in line with what I've seen in other themes
Yes. This theme have the same appearence with the ys.zsh-theme in oh-my-zsh, and it is quite similar with rana theme in oh-my-bash.
oh-my-bash is a very good project that aims to improve the experience of bash users.
So what I am trying to do is to bring one of my favorite theme ys.zsh-theme, which is a very common used theme in OMZ, to OMB. To realize it, I borrow the code template from the similar theme rana, recolored it, and also make some improvements, like, fixing bugs of misplaced commands, adding missing python env and etc.
Finally, is this commit OK? Can it be merged into master branch or not? What should I do next?
Thanks again!
I'm thinking of taking over this PR. If you still would like to work on it by yourself, please let me know.
I have rebased the PR on top of the latest master, applied suggested changes, and added other fixes. I have also added an image of the theme in themes/THEMES.md. I'll keep this PR for about one week and am going to merge it if there is no further comments. @nntoan If you would like to review the PR, please let me know, in which case I'll wait for your review before merging.