ohm-editor icon indicating copy to clipboard operation
ohm-editor copied to clipboard

Expand emoji support in "Explain Parse" preview

Open s-gbz opened this issue 3 years ago • 2 comments

A note of gratitude

Hey there! First of all: Thanks a lot for your continuous effort in developing Ohm & the Ohm-Editor. It's much much appreciated and will most likely be a backstone in my emoji driven programming language (& master's thesis).

Feature suggestion

Regarding the issue's title: Have you considered expanding the preview's emoji support? The tree leaves seem to allow the browser to display emojis natively. The "overview" doesn't seem to parse the unicode correctly tough.

I haven't looked into the code yet, however I expect it to be a rather quick fix/ adaption.

image

Call to action

Is this issue something you might consider worthwhile? Is this sth. you might want to tackle? Are there any pointers you could give me to look into the code myself? I can't make any promises since I myself don't prioritize this issue that much, but "the long winter nights" are coming - who knows!

Thanks again and best regards from Bochum, Ruhr Valley ;)

s-gbz avatar Sep 30 '21 15:09 s-gbz

Hi Sergej! First off, I appreciate the thank-you note! I started working on this project as part of my work, but for the past four years it's all been done in my free time, so it's really nice to hear something like this.

To answer your questions:

  • Yes, I'd absolutely like to fix this.
  • I might be able to tackle it, but I'm not sure that I'd be able to look into it any time soon.
  • That text is part of the expanded-input component, and I believe it's rendered here. Off the top of my head, I don't know why it's not rendered properly, because AFAIK, fillText should render emoji properly on a canvas. If you have a chance to look into it, that would be great. Feel free to post more questions here if you are able to investigate it.

pdubroy avatar Sep 30 '21 17:09 pdubroy

Hey there @pdubroy just wanted to give you a little heads up that I've started looking into the editor's code. There're a couple small adjustments I hacked in my own fork and I will definitely provide some PRs with issues. However, that might take a while, because I'm too heel over head in other projects.

Anyways, thanks for the pointer and see you soon!

s-gbz avatar Oct 19 '21 08:10 s-gbz