OldInsuranceMaps icon indicating copy to clipboard operation
OldInsuranceMaps copied to clipboard

[Bug] When using dropdown to navigate pages download and web service links disappear

Open hdevine825 opened this issue 1 year ago • 1 comments

Describe the problem When looking at a georeferenced page of a volume (example), using the dropdown to navigate to another georeferenced page navigates you to a view that does not include download and web service links.

Expected behavior Instead it should take you to this page.

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the downloads and web services page for a volume page such as https://oldinsurancemaps.net/layer/42988
  2. Use the dropdown to reach another volume page.

Environment info:

  • Device: laptop
  • Operating System: Windows
  • Browser: Chrome

hdevine825 avatar Dec 18 '24 04:12 hdevine825

@hdevine825 Thanks for pointing this out, because these pages are pretty messy right now... it's kind of a mishmash from how things were originally designed + some patching to handle a new data model I moved to in the late summer.

To explain what's going on a bit more, there are three different categories of content that are displayed in these "resource" pages like you are talking about: /document/<id> for unprepared, original sheets, /region/<id> for prepared pieces (or entire sheets if not split), and /layer/<id> for actual geospatial layers. The left dropdown you are referring to will switch between /document views, and the right one switches between /region views. I'm realizing now that the only way to get to /layer views is through the direct links on the map/volume summary page.

This will be solved with a reworking of how these pages are constructed, and thinking about this now, here's an approach I like moving forward:

  • Document page will be treated a little differently from Region/Layer pages
  • Region/Layer pages will have an easy way to switch back and forth (the icons in the top right bar used to do this but aren't entirely operational anymore)
  • Left dropdown remains the same
  • Right dropdown only shows the Regions from the document that is selected in the left dropdown
  • Selecting an item in the right dropdown will go to the appropriate Region/Layer page, preferring the Layer page if that region has been georeferenced.

Each other feature of these pages, like the session history list, the web services links, etc. will need to be re-evaluated with the context described above in mind.

I'm not sure when I'll be able to get to this, but I'm glad you brought it up because it definitely needs some work. Open to other ideas for how this is handled as well...

mradamcox avatar Dec 18 '24 15:12 mradamcox