ojg icon indicating copy to clipboard operation
ojg copied to clipboard

Support Indexed and Keyed interfaces when removing nodes

Open twelvelabs opened this issue 6 months ago • 2 comments

This PR adds support for the Indexed and Keyed interfaces when removing nodes from an expression.

Note: I needed to add a method for removing items from Indexed. If you'd rather avoid a breaking change, we could move RemoveValueAtIndex to a separate interface. I originally went down that route, but got stuck trying to come up with a name. MutableIndexed was the only thing I could come up with and... it doesn't really sound great to me 😬. Let me know what you prefer (or feel free to take over this PR).

Also, a belated thank you for fixing #156 ❤️! I tried out the latest release and it works great.

twelvelabs avatar Aug 13 '24 05:08 twelvelabs