plugin-thefuck icon indicating copy to clipboard operation
plugin-thefuck copied to clipboard

Add Ctrl+F as a shortcut for "fuck"

Open oranja opened this issue 8 years ago • 3 comments

Using OMF's new support for adding shortcuts from plugins (and themes), I suggest to add Ctrl+F as a shortcut for running fuck. Not sure about this specific binding, but I find it reasonable.

oranja avatar Jun 22 '16 06:06 oranja

Hey, @oranja. I think key bindings are a very personal stuff and perhaps it's not a good idea to mess with it, even the user's key bindings having precedence over the plugin's.

That's why there is an Optional key binding section in the docs. The plugin already offers support for that, as there are some other things involved like bypassing some user (or default) settings and calling thefuck directly.

Thinking over it, we could manage (OMF-wise) to have some advice at installation time, just like brew's “caveats”, and tell the user what the plugin offers. What you think?

scorphus avatar Jun 22 '16 13:06 scorphus

Hey,

I agree that bindings are personal, but Fish is opinionated software, and I think it's fine for some of the plugins to follow suit. The considerate thing to do would be to add a config option to set another sequence (make it empty to disable the feature).

thefuck-command-line is awesome :+1:

Showing advisories on install sounds like an intelligent feature that might close this gap. If there will be too much text it will be useless, of course, but otherwise it should be great. Maybe the key here is to think lazy (a.k.a "seamless integration"/"minimum friction"): Type less, read less, don't open the browser. Nevertheless, shame on me for submitting a PR before even reading the README... Sorry. :disappointed:

oranja avatar Jun 22 '16 13:06 oranja

Don't need to be sorry 😃 we all do that all the time 😜 (/me totally included) 😂

You've added some good points, Itzik. Let's see how a “caveats” thing looks, I think we can code it along this week and come up with a PR? Then we retake this matter into consideration, see what we do. Also, it'd be good to read others' opinions.

scorphus avatar Jun 22 '16 13:06 scorphus