packages-main icon indicating copy to clipboard operation
packages-main copied to clipboard

add new theme: powerline-shell wrapper for fish

Open leleliu008 opened this issue 5 years ago • 4 comments

add new theme: powerline-shell wrapper for fish

leleliu008 avatar Oct 03 '19 14:10 leleliu008

Would you mind removing the -theme from the end of the filename? It's not necessary because the package type is defined by the package definition file.

derekstavis avatar Jan 25 '20 22:01 derekstavis

@derekstavis can't remove the -theme from the end of the filename for the following reasons:

  1. a package who is named powerline which type is plugin already exist. it is wrapped for powerline-status
  2. my new package's type is theme, it is wrapped for powerline-shell

leleliu008 avatar Jan 30 '20 07:01 leleliu008

installing this theme sets fish keybindings to vi mode (and this persists even after removing the theme). this feels like … not the sort of thing a theme should do :)

bobthecow avatar Jan 31 '20 14:01 bobthecow

@bobthecow I have removed the key_bindings.fish

leleliu008 avatar Feb 01 '20 04:02 leleliu008