oh-my-fish icon indicating copy to clipboard operation
oh-my-fish copied to clipboard

Cannot install Flash theme

Open adrianObel opened this issue 6 years ago • 6 comments

omf install flash doesn't seem to work and the repo that it points to 404s. Might want to pull this off the list

adrianObel avatar Sep 20 '18 14:09 adrianObel

I had a copy of this theme on my machine and I have mirrored it here: https://github.com/alecgorge/fish-flash-theme

alecgorge avatar Oct 05 '18 18:10 alecgorge

Hmm, unfortunate. We can update the package index to point to your mirror.

sagebind avatar Dec 31 '18 17:12 sagebind

Hello from the future! I just came across this myself and am quite keen on installing the theme. I'd just contribute the change myself but I'm brand new to omf.

lukerollans avatar Jul 23 '19 14:07 lukerollans

So apparently someone removed the repo from oh-my-fish/packages-main, but you can add it back in pointing to the new repo.

I'll walk you through the process:

  1. Fork https://github.com/oh-my-fish/packages-main/
  2. Clone your fork and create a new file packages/flash (or use the GitHub online editor)
  3. Add all the necessary info to the file and commit your changes
  4. Create a pull request
  5. Have it merged, install flash and be happy

The files in packages-main follow a simple TOML format, here's what that's going to look like for flash:

type = theme
repository = https://github.com/alecgorge/fish-flash-theme
description = Please describe me
maintainer = Alec Gorge <[email protected]>

Just fill in a better description and you'll be good to go :)

kfkonrad avatar Jul 23 '19 14:07 kfkonrad

PR opened 👌

lukerollans avatar Jul 24 '19 01:07 lukerollans

PR is merged, this issue should be closable now

lukerollans avatar Jul 31 '19 02:07 lukerollans