Results 116 comments of Olivier Guimbal

😄 My two cents: If implementing the whole documentation linked, there must be two statements. The `SET TRANSACTION SNAPSHOT ` one should be pretty straightfoward... something like this should do:...

Ouch. Yes, there are quite a lot of lookbehind expressions in [the lexer](https://github.com/oguimbal/pgsql-ast-parser/blob/master/src/lexer.ts), and it would seem that [Safari doesnt like them](https://caniuse.com/js-regexp-lookbehind). The lexer is a very sensitive thing: Changing...

Hi ! That's a tough nut to crack... First, because I dont know plpgsql that much. Second, because I dont have time these days. So I think I will do...

Yes, you got it right 😊 That's exactly what I had in mind.

Nice ! Thanks. Dont hesitate if you have questions. Some details I can think of: - The `wrap()` calls you will see everywhere are here to track statement locations. -...

@m-rutter Yup, that's a bit like data validation, but using Joi or equivalent might often be overkill. The example I used in this PR is a bit misleading, my bad...

> your codegen and I/O layer is allowing invalid input to reach your leaves of the application. Well, yes and no. It does validate the data received, but I dont...

Hi ! I'm not familiar with exclude constraint so I will have to dig a bit around that before implementing it 🤷‍♂️ As for a workaround, it depends if you...

For the parser => Easy one. Done. I had to introduce [a typing breaking change](https://github.com/oguimbal/pgsql-ast-parser/commit/ce8633ec8997732a5bb29004427cc40237e7b079#diff-63e3f1e3ce1fbdf3a9d0272440506e7a83f798a4cba12a8552305265b9c95c67R366), though (`columns` has changed in `CreateTableStatement`)... meaning we're now at `[email protected]`. I'm moving this to...