tf-gqn icon indicating copy to clipboard operation
tf-gqn copied to clipboard

Self-Attention and other extensions

Open loganbruns opened this issue 5 years ago • 2 comments

@ogroth, as mentioned in #27 I've found it useful to add self-attention and also some additional training options to limit the amount of data used for training. Also a simple test script. Would you please take a look at my branch and give me an idea of what parts you might consider including and I'll create a pull request with that subset?

https://github.com/ogroth/tf-gqn/compare/master...loganbruns:sa_gqn

Thanks, logan

loganbruns avatar Jun 19 '19 14:06 loganbruns

The self-attention encoder you've added in gqn_encoder.py looks neat. Can you send me a pull request for that on the attention_encoder branch?

ogroth avatar Jun 21 '19 13:06 ogroth

@ogroth, thanks. I created a pull request with just the self-attention encoder in this pull request:

https://github.com/ogroth/tf-gqn/pull/30

I was wondering if you might be interested in a separate pull request against master with the limited training flags, --train_subset, from the branch above as well?

loganbruns avatar Jun 23 '19 07:06 loganbruns