Olivier Grisel
Olivier Grisel
@EmilyXinyi the `main` has evolved concurrently and there is now a bunch of conflicts. Would you mind updating the PR to resolve those. Please let me know if you need...
BTW, to set the environment variable in the colab notebook, you would need to do: ```python import os os.environ["SCIPY_ARRAY_API"] = "1" ``` in one of the first cells, before importing...
> I have made the suggested changes to azure-pipelines.yml and .github/workflows/cuda-gpu-ci.yml, and here is the colab link for cuda and nightly build of scipy: https://colab.research.google.com/drive/1Dw6ABHw-2wyjlzUQKb4VDJw_51mGZMLn?usp=sharing Seems like the tests are...
@EmilyXinyi I merged the `main` branch into this PR to hide redundant changes related to the `chi2_kernel` thingy. Be sure to pull this merge commit to your local branch before...
>> Should we instead check when enabling array API support and print a warning to the user? > Should this change be made this PR? (If yes, could anyone help...
#29436 was merged. Please feel free to merge `main` into this PR and address https://github.com/scikit-learn/scikit-learn/pull/29227#discussion_r1670089775.
/cc @betatim you might also want to have a look at this PR.
@AlexanderFabisch do you think you will have time addressing the last batch of review comments or would you rather like someone else to take over that PR to finalize it?
> @charlesjhill was working on this PR during the last weeks. Sorry, I forgot that this PR had 2 active contributors.
> That's right, but not the standard in our code base. If you wish to correct that, I propose a separate PR. I think we can just make sure that...