Maksim Bondarenkov

> @ognevny Can you fix these issues? > > p/s: I'm back. I didn't find any file for icon/manifest. `-mwindows` is already used as link flag: https://gitlab.gnome.org/GNOME/evince/-/blob/main/meson.build?ref_type=heads#L109

pushed an update to 46.3

should I backport this change?

> That's up to you. It's just cosmetics at this point 😅. And it's not only text, you'd also have to add the .ico file to the patch. I guess...

@hmartinez82 what does this mean? ``` FAILED: shell/shell_evince.rc_evince.o "C:\msys64\clang64\bin/windres.EXE" "../evince-46.3/shell/evince.rc" "shell/shell_evince.rc_evince.o" "--preprocessor-arg=-MD" "--preprocessor-arg=-MQshell/shell_evince.rc_evince.o" "--preprocessor-arg=-MFshell/shell_evince.rc_evince.o.d" llvm-rc: Error in ICON statement (ID Icon): Incorrect icon/cursor Reserved field; should be 0. ```

in recipe I copied the ico (I downloaded it separately) with `cp -a ${srcdir}/evince.ico shell`. is the path correct?

in UCRT64 I get ``C:\msys64\ucrt64\bin/windres.EXE: icon file `./../evince-46.3/shell/evince.ico' does not contain icon data``

> The new files should be `shell/evince.rc` `shell/evince.ico` and there are changes to `shell/meson.build` I download the patch, but removed .ico file from there. I download it separately from `https://gitlab.gnome.org/GNOME/evince/-/blob/24967ecf7f658bb69e512d6e09287c1ccc02c11c/shell/evince.ico`

> > in UCRT64 I get `` C:\msys64\ucrt64\bin/windres.EXE: icon file `./../evince-46.3/shell/evince.ico' does not contain icon data `` > > Then you are definitely missing a file. Look at the original...

I guess I can't push it