httpriot icon indicating copy to clipboard operation
httpriot copied to clipboard

Pullrequest add authentication support

Open eilers opened this issue 14 years ago • 3 comments

Hi!

Caged told me that you are managing the official fork of this project.

I have finished my integration of https authentication and would like to discuss whether it might be added into the main stream. The code works here in my local application.

It handles the two NSURLConnection delegate functions:

(BOOL)connection:(NSURLConnection )conn canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace )protectionSpace

(void)connection:(NSURLConnection )conn didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge )challenge

and adds a ChallengeHandler Class that is managing the incoming requests.

Todo: The ChallengeHandler currently uses static Classnames for the various handlers. I would change this before merging.

Btw.: The code was taken from the great example "AdvancedURLConnections", provided by Apple.

What do you think?

eilers avatar Mar 10 '11 08:03 eilers

Hey!

Definetly! The funny thing is that I implemented exactly the same thing a month ago but was too busy with day work projects to push it up stream. I also found some issues in NSURLConnection while at it.

Tell you what: I'll push my branch as well and you look at it and tell me what you think. I will look at your pull request and we'll merge the best of both approaches to the master.

Ognen

ognen avatar Mar 10 '11 09:03 ognen

Ok. I'm looking forward to see your solution. :)

eilers avatar Mar 10 '11 14:03 eilers

Hi! You wanted to publish your branch in order to decide which solution is the best! :)

eilers avatar Jun 02 '11 10:06 eilers