tab-switcher icon indicating copy to clipboard operation
tab-switcher copied to clipboard

Incompatibility with plugn x-terminal -> Uncaught TypeError: Cannot read property 'id' of null

Open bilbonotry opened this issue 2 years ago • 0 comments

Description

When opening a terminal tab with plugin x-terminal (https://github.com/bus-stop/x-terminal) tab-switcher throws an error and then each time I hit Ctrl+tab

Steps to Reproduce

  1. Install tab-switcher in Atom
  2. Install x-terminal in Atom
  3. Hit Ctrl-Shit-T to open a terminal -> error
  4. Hit Ctrl+Tab to switch window -> error

Expected behavior:

Terminal opens.

Actual behavior:

Terminal opens but there is an atom error pop-up.

Versions

Atom: 1.60.0 x64 Electron: 9.4.4 OS: Ubuntu 18.04.6 Thrown From: tab-switcher package 1.5.6

Stack Trace

Uncaught TypeError: Cannot read property 'id' of null

At /home/user/.atom/packages/tab-switcher/lib/tab-list-view.coffee:99

TypeError: Cannot read property 'id' of null
    at TabListView.tabUpdated (/packages/tab-switcher/lib/tab-list-view.coffee:99:16)
    at /packages/tab-switcher/lib/tab-list.coffee:51:15
    at Function.simpleDispatch (/usr/share/atom/resources/app/static/<embedded>:11:1187666)
    at Emitter.emit (/usr/share/atom/resources/app/static/<embedded>:11:1189107)
    at /packages/x-terminal/src/utils.js:60:13
    at Array.forEach (<anonymous>)
    at recalculateActive (/packages/x-terminal/src/utils.js:58:12)
    at /packages/x-terminal/src/x-terminal.js:142:5
    at Function.simpleDispatch (/usr/share/atom/resources/app/static/<embedded>:11:1187666)
    at Emitter.emit (/usr/share/atom/resources/app/static/<embedded>:11:1189107)
    at Workspace.didChangeActivePaneItemOnPaneContainer (/usr/share/atom/resources/app/static/<embedded>:11:428429)
    at /usr/share/atom/resources/app/static/<embedded>:14:45152
    at Function.simpleDispatch (/usr/share/atom/resources/app/static/<embedded>:11:1187666)
    at Emitter.emit (/usr/share/atom/resources/app/static/<embedded>:11:1189107)
    at PaneContainer.didChangeActiveItemOnPane (/usr/share/atom/resources/app/static/<embedded>:11:450818)
    at Pane.setActiveItem (/usr/share/atom/resources/app/static/<embedded>:11:459752)
    at Pane.activateItem (/usr/share/atom/resources/app/static/<embedded>:11:461922)
    at TabList.module.exports.TabList.select (/packages/tab-switcher/lib/tab-list.coffee:159:17)
    at /packages/tab-switcher/lib/tab-switcher.coffee:76:60)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11:352694)
    at KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11:1228469)
    at KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app/static/<embedded>:11:1224603)
    at WindowEventHandler.handleDocumentKeyEvent (/usr/share/atom/resources/app/static/<embedded>:11:286682)

Commands

  2x -3:29.5.0 core:backspace (input.hidden-input)
     -3:06.4.0 editor:move-to-end-of-screen-line (input.hidden-input)
  3x -3:01.8.0 core:backspace (input.hidden-input)
     -2:51.5.0 editor:newline (input.hidden-input)
     -2:50 core:backspace (input.hidden-input)
     -2:49.6.0 github:commit (input.hidden-input)
  3x -2:22.1.0 core:confirm (input.hidden-input)
     -1:33.9.0 editor:newline (input.hidden-input)
     -1:32.6.0 core:backspace (input.hidden-input)
     -1:32.1.0 github:commit (input.hidden-input)
     -1:15.7.0 x-terminal:open (div.)
     -1:01.2.0 x-terminal:reorganize-bottom (div.title.icon.icon-terminal)
     -0:27.2.0 x-terminal:reorganize (div.line.cursor-line)
  6x -0:14.5.0 tab-switcher:next (input.hidden-input)
     -0:11.2.0 tab-switcher:select (ol.tab-switcher-tab-list)
     -0:09.2.0 core:confirm (ol.tab-switcher-tab-list)

Non-Core Packages

atom-java-decompiler 0.1.2 
atom-maven 1.3.2 
atom-xmlvalidate 0.5.0 
busy-signal 2.0.1 
compare-files 0.8.1 
file-icons 2.1.47 
git-plus 8.7.1 
git-time-machine 2.1.0 
intentions 2.0.0 
iv-terminal 1.3.1 
language-ansible 0.2.2 
linter 3.4.0 
linter-ansible-linting 1.8.0 
linter-ansible-syntax 1.3.1 
linter-autocomplete-jing 0.8.4 
linter-shellcheck 1.6.0 
linter-ui-default 3.0.2 
minimap 4.39.14 
minimap-cursorline 1.0.5 
print-code 0.7.1 
project-plus 1.0.0 
quantum-shell 0.7.1 
remote-sync 4.1.8 
split-diff 1.6.1 
Sublime-Style-Column-Selection 1.7.5 
susave 0.4.0 
tab-switcher 1.5.6 
teletype 0.13.4 
x-terminal 13.1.0 
xml-formatter 0.13.0 

bilbonotry avatar Jun 03 '22 15:06 bilbonotry