curlify icon indicating copy to clipboard operation
curlify copied to clipboard

Python 3 compat, tests

Open tony opened this issue 6 years ago • 4 comments

Adds tox.ini file. Use like this: tox

Tox is set to run at python 2.7 and 3.7

Rename curlify_test -> test_curlify so it's detected by pytest

Add Pipfile/Pipfile.lock with tox, pytest, and the file as an editable package. To use run pipenv shell

tony avatar Jun 06 '19 15:06 tony

Looks great, thanks!

And about small test I mean if it is possible to reproduce bug that is fixed by your MR so it can be unit-tested?

ofw avatar Jun 07 '19 09:06 ofw

And about small test I mean if it is possible to reproduce bug that is fixed by your MR so it can be unit-tested?

I'm having a problem with that.

I don't seem to be able to reproduce the conditions. Even when I revert bfa5b18a0f30567a178cf1abb01be7c24979f7d2.

Is that a requirement to merge it in?

curl -X 'POST' -H 'None: /' -H 'None: gzip, deflate' -H 'None: OAuth oauth_nonce="2", oauth_timestamp="3", oauth_version="1.0", oauth_signature_method="HMAC-SHA1", oauth_consumer_key="4", oauth_body_hash="5", oauth_signature="6"' -H 'None: keep-alive' -H 'None: None' -H 'None: application/xml' -H 'None: python-requests/2.19.1' -d '

I can confirm that without this PR, I get the above.

tony avatar Jun 07 '19 15:06 tony

@ofw Rebased against b914625

tony avatar Apr 07 '20 17:04 tony

Originally, I never intended to support python2, so it is better to remove completely any py2 compatibility

ofw avatar May 21 '20 10:05 ofw