Omar Olivares Urrutia comments

Results 31 comments of


                                            Omar Olivares Urrutia

PDF of English and Traditional Chinese versions

hey @krahets , how can I test the current PDF version for English? I'm using Docker already =)

PDF of English and Traditional Chinese versions

Thanks @seven1240 I'll take a look and get back to you ASAP

PDF of English and Traditional Chinese versions

Found an error in [Table 3-1](https://www.hello-algo.com/en/chapter_data_structure/basic_data_types/) `Space occupied and value range of basic data types`, the value of `boolean` it should be `bit` not `byte`, I think is an example...

PDF of English and Traditional Chinese versions

Overflow error in the PDF too, on page 88-89

PDF of English and Traditional Chinese versions

hey @seven1240 and @krahets, can you generate a ePub for the English version to review it?

PDF of English and Traditional Chinese versions

@krahets nice! waiting for it.

Not supported on Kindle

I use Apple Books and it works perfectly for me, try with [this](https://kindle-epub-fix.netlify.app) tool, maybe that helps

Not supported on Kindle

Is it working now, @Achllle? Can you try with the build from [here](https://github.com/ofou/graham-essays/releases/tag/latest)?

The collection doesn't include the last few essays

I wonder why it stopped updating it, I'll find a workaround

BPE Tokenizer

Is there any way to use a custom tokenizer by the way? (like UTF-8 ids) I'd be cool to get rid of the tokenizer itself, obviously at the expense of...