react-favicon icon indicating copy to clipboard operation
react-favicon copied to clipboard

Published 20 hours ago • verified publisher icon oflisback

Dark mode

Open Angelk90 opened this issue 2 years ago • 3 comments

Hi @oflisback , It would be possible to set up a props that would allow you to support theme switching.

Link: Blog

Angelk90 avatar Mar 09 '22 13:03 Angelk90

That sounds interesting, is there some part of it that can't be accomplished already from the client side considering that you can set alert fill and text color?

oflisback avatar Mar 15 '22 18:03 oflisback

@oflisback : It could be done on the client side, but I think giving the opportunity that it is implemented on the library side would be better. With the possibility of a prop that if you require that in the change of theme to use an icon for dark mode, a prop that returns if you are in dark mode or not, in case you do not want to implement prop for the dark mode specific text.

Angelk90 avatar Mar 15 '22 21:03 Angelk90

Ok, in my mind it's better to keep this out of the library, I just don't feel that it adds enough convenience.

oflisback avatar Mar 17 '22 20:03 oflisback