kiwix-hotspot icon indicating copy to clipboard operation
kiwix-hotspot copied to clipboard

kiwix-hotspot: use shutil to find correct bin path.

Open Ark74 opened this issue 2 years ago • 3 comments

Starting on Ubuntu 22.04

mount.exfat link to binary mount.exfat-fuse no longer exists,

  • exfat-fuse: /sbin/mount.exfat-fuse

Another change is the exfat-utils package now provided by exfatprogs changes binaries location,

  • exfatprogs: /usr/sbin/dump.exfat
  • exfatprogs: /usr/sbin/exfatlabel
  • exfatprogs: /usr/sbin/fsck.exfat
  • exfatprogs: /usr/sbin/mkfs.exfat
  • exfatprogs: /usr/sbin/tune.exfat

So, maybe we can use shutil.which to find the binary path regardless of the version.

Ark74 avatar Sep 09 '23 10:09 Ark74

Thank you @Ark74 ; we're working on a new (command-line only for now) version of the tool and I can't quite commit the time to test your PR and make a new release. I'll come back to this later.

rgaudin avatar Sep 09 '23 15:09 rgaudin

No problem, thanks for taking the time to mention it.

Ark74 avatar Sep 09 '23 15:09 Ark74

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 16 '23 18:09 stale[bot]