kiwix-hotspot icon indicating copy to clipboard operation
kiwix-hotspot copied to clipboard

GUI space checker should consider content size as well

Open kelson42 opened this issue 3 years ago • 3 comments

And report an error otherwise

kelson42 avatar Feb 16 '22 15:02 kelson42

See #636 for example for an idea of the user impact

kelson42 avatar Feb 16 '22 15:02 kelson42

It seems we are only accounting for SD card size to display the warning in GUI mode. In the example below, we want a 256G card plus 100+G of content and it only requires those 256G.

We already have a proper card size + content size check in CLI mode, that we should port to GUI.

Screen Shot 2022-02-16 at 16 48 56

rgaudin avatar Feb 16 '22 15:02 rgaudin

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Apr 18 '22 18:04 stale[bot]

This has been implemented in image-creator.

kelson42 avatar Jun 04 '24 19:06 kelson42