offspot
Add "external links" off switch
From a user: "I noticed that clicking links that go out to external pages with an "https" in the URL delivers an error message that's a bit disconcerting to non-technical users."
Since most use cases relate to people being offline, there is no point in letting them click on links to nowhere that will worry them more than anything. Could it be possible to have a switch feature before building the image that inactivates these external links by default (but can be reactivated if need be)?
For kiwix-serve, we have a feature (not enabled on hotspot) that catches external links and displays a warning. We could enable that on the hotspot and let them know that if they get the warning, it's because the hotspot is not connected to Internet and this the external link is useless.
A second iteration could check the Internet connection status and behave differently (either different message or just redirect to the destination).
@rgaudin Yes this is probably a bettre approach to configure this per default as the use case where a Kiwix-Hotspot is online is a rare one.
@SRDdev Yes, would you be able first to explain here how your solution woukd look like?
Sorry I thought about it and found some technical issues in my solution, you can pass it on @kelson42 Thank you so much @kelson42 !!
@SRDdev if you found the issues, then you are halfway to solving them ;-)
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}