nethunter-app icon indicating copy to clipboard operation
nethunter-app copied to clipboard

Mount fixes

Open kimocoder opened this issue 5 years ago • 10 comments

  • bootkali slightly improved

  • killkali now works good, several mount issues suppressed.

  • Should had a check for external_sd in future when you not have it, something with mounts gets weird

*The same for /dev/shm, a check if it exists then unmount If not, why then try at all

  • Added a "get-keychain" tool for pulling those apt-get issues, probably put a button in CustomCommads.

Forgot to add the get-keychain to the transfer/install script. will do.

kimocoder avatar Apr 23 '19 11:04 kimocoder

Screenshot_20190423-072546

kimocoder avatar Apr 23 '19 11:04 kimocoder

Is there more coming to mount the external_sd? Do we need the installation of the keyring? Wouldn't it be more likely that people with key issues download a new chroot rather than a new nethunter app?

Re4son avatar Apr 23 '19 11:04 Re4son

It needs a check if external_sd actually exists instead of power run through The same for /dev/shm partition, needs a check if supported/found. My Nexus don't have it, OP6 got it again. Switches.

The get-keychain is more of an backup (used it alot past months again)

I'll get back to it soon. But as is, works good.

kimocoder avatar Apr 23 '19 11:04 kimocoder

So only works on phones without sd card, right?

Re4son avatar Apr 23 '19 11:04 Re4son

The internal memory of Android is "sdcard", while "external_sd" is the physical card. Phones who do not have external_sd (newer phones) will get mount issues, both on bootkali and killkali. But everyone has the /sdcard (internal memory) storage.

kimocoder avatar Apr 23 '19 12:04 kimocoder

And you have this /dev/shm and /dev partition available.

kimocoder avatar Apr 23 '19 12:04 kimocoder

Correct. What problems are we trying to solve? We seem to have had no issues with this commit: https://github.com/offensive-security/nethunter-app/commit/e4d7b9c223f60fb052ab99da7814c0cb90b78d45#diff-93d8f5c7f9f0edbf4090568456fea24b And now we can't get the external sd card to mount. Why can't we roll back to the last known working commit? Is it Androind O or P related?

Re4son avatar Apr 23 '19 12:04 Re4son

By mount "issues", do you mean a warning that it cannot mount for any reason? That's not entirely undesirably because it tells us what's going on.

Re4son avatar Apr 23 '19 12:04 Re4son

warnings is easy to go away, uncomment. no, but it try running those two last ones, so it's basicly just add check if exists, easy but I don't have more time atm

kimocoder avatar Apr 23 '19 12:04 kimocoder

No rush. I'll revert back to jcadduono's commit from 2017 and we'll leave that on the todo list for 2019.3, ok?

Re4son avatar Apr 23 '19 12:04 Re4son