docker-volume-backup icon indicating copy to clipboard operation
docker-volume-backup copied to clipboard

Published 20 hours ago • verified publisher icon offen

Allow the use of a custom CA certificate

Open zaggash opened this issue 3 years ago • 1 comments

Describe the solution you'd like To avoid the use of

  • AWS_ENDPOINT_INSECURE: "true"

It would be nice to be able to add our own self-signed CA

Describe alternatives you've considered Using - AWS_ENDPOINT_INSECURE: "true" is working but not ideal

zaggash avatar Sep 19 '22 13:09 zaggash

It's possible to pass a custom HTTP transport to the Minio Client and it's already done here for example: https://github.com/offen/docker-volume-backup/blob/00c83dfac79af6f03c677e187b5bce6817b2c2a7/internal/storage/s3/s3.go#L61-L72

If someone wants to add an option that allows using a custom CA cert (not sure how the API would look like right now, but I guess it should be straight forward), I'm happy to review and merge PRs regarding that feature.

m90 avatar Sep 19 '22 14:09 m90

This is now possible as of v2.23.0 which lets you provide a CA certificate by passing AWS_ENDPOINT_CA_CERT.

You can also check the test case to get an idea of how it works in conjunction with a MinIO server that is using a self signed certificate: https://github.com/offen/docker-volume-backup/blob/9534cde7d967c08e1c7d3a8d3859a6449d4e86d0/test/certs/docker-compose.yml

m90 avatar Dec 22 '22 13:12 m90