ng2-completer icon indicating copy to clipboard operation
ng2-completer copied to clipboard

Angular 10 Update Generic type 'ModuleWithProviders' requires 1 type argument(s).

Open PauloPeres opened this issue 4 years ago • 6 comments

WHERE: @akveo/ng2-completer/src/modules/ng2-completer.module.d.ts:3:23 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s). 3 static forRoot(): ModuleWithProviders;

According to Angular 10 it's now necessary to have a generic type https://angular.io/guide/migration-module-with-providers

PauloPeres avatar Jul 23 '20 20:07 PauloPeres

Hopefully a fix for this soon!

vamidi avatar Oct 21 '20 18:10 vamidi

@vamidi sent a pull request but looks like no one answered yet, not sure if this rep has people maintaining.

PauloPeres avatar Oct 21 '20 18:10 PauloPeres

So unfortunate that there is no update there are a few frameworks that rely on this.

vamidi avatar Oct 21 '20 18:10 vamidi

I used patch-package with

diff --git a/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts b/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
index f1dd11a..860a84c 100644
--- a/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
+++ b/node_modules/ng2-completer/src/modules/ng2-completer.module.d.ts
@@ -1,5 +1,5 @@
 import { ModuleWithProviders } from "@angular/core";
 export declare class Ng2CompleterModule {
-    static forRoot(): ModuleWithProviders;
-    static forChild(): ModuleWithProviders;
+    static forRoot(): ModuleWithProviders<Ng2CompleterModule>;
+    static forChild(): ModuleWithProviders<Ng2CompleterModule>;
 }

As a stop gap

Hopefully a more permanent fix is merged soon.

aaron-harvey avatar Oct 22 '20 03:10 aaron-harvey

Thanks @aaron-harvey that tool is awesome! :)

BruneXX avatar Mar 16 '21 16:03 BruneXX

Hi All,

I have forked the project and fixed the issue, If anyone wants the fix, replace your "ng2-completer": "^9.0.1" dependency line in package.json with this line: "ng2-completer": "git+https://github.com/dilankamr/ng2-completer.git"

Or run the command: npm install git+https://github.com/dilankamr/ng2-completer.git --save

And do an npm install.

Then, your project will run nicely without any issue. :)

Thanks

dilankamr avatar Mar 25 '21 21:03 dilankamr