ofxCef icon indicating copy to clipboard operation
ofxCef copied to clipboard

Make it work

Open michaelbaisch opened this issue 7 years ago • 5 comments

This pull request tries to bring the setup steps down to a minimum and makes the entry barrier as small as possible. While making it work on macOS and Windows in a reproducible way. This might be the new common ground to further improve ofxCef and discuss detail problems instead of using energy on "how to compile"-problems.

  • Use apothecary to automatically build the CEF lib
  • Use the PG as much as possible to create new projects
  • There are only two (macOS) / one (windows) manual steps left to do
  • Add a way to bind JS functions to C++ methods
  • Add examples: simple, communication, and multi
  • Describe everything in the readme
  • Use ofBaseDraws to have nice drawing methods
  • Fix bug where uninitialized variables in the renderHander would lead to crashes

Closes #38 #36 #34 #32 #31 #29 #28 #27 #23

michaelbaisch avatar Jan 15 '18 16:01 michaelbaisch

Wow, nice. I'm definitely going to give this a try.

anselanza avatar Apr 19 '18 09:04 anselanza

Hi Michael, I tried to build your fork using the apothecary, but it fails like this:

Richard@RRJ-MSI MINGW64 /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts
$ git clone https://github.com/openframeworks/apothecary
Cloning into 'apothecary'...
remote: Counting objects: 6147, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 6147 (delta 0), reused 0 (delta 0), pack-reused 6144
Receiving objects: 100% (6147/6147), 15.54 MiB | 700.00 KiB/s, done.
Resolving deltas: 100% (4130/4130), done.

Richard@RRJ-MSI MINGW64 /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts
$ cd apothecary/apothecary

Richard@RRJ-MSI MINGW64 /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary (master)
$ ./apothecary update ofxCef
OF: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/../../../
APOTHECARY: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary
FORMULAS: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/formulas
BUILD: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/build
LIBS_DIR: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/../
ADDONS: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/../../../addons
REL_ADDONS_DIR: /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary/../../../addons
./apothecary: line 327: shift: too many arguments
 Skipping addon "ofxCef": no formulas found

Richard@RRJ-MSI MINGW64 /c/Igloo/Dev/of_v0.10.0_vs2017_release/scripts/apothecary/apothecary (master)

any ideas?

BTW, I wanted to raise this as an issue on your fork, but you don't have issues enabled, so I hope its OK to raise it here.

rjx-ray avatar Jul 24 '18 08:07 rjx-ray

@rjx-ray I've enabled issues on my fork now.

Just to be sure, did you switch to to the make_it_work branch?

michaelbaisch avatar Jul 24 '18 09:07 michaelbaisch

Thanks for the quick response Michael, I’ll double check.

BTW do you have any idea about https://github.com/ofZach/ofxCef/issues/40

  • Richard

From: Michael Baisch [email protected] Sent: 24 July 2018 10:10 To: ofZach/ofxCef [email protected] Cc: Richard Jackson [email protected]; Mention < [email protected]> Subject: Re: [ofZach/ofxCef] Make it work (#39)

@rjx-ray https://github.com/rjx-ray I've enabled issues on my fork now.

Just to be sure, did you switch to to the make_it_work branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ofZach/ofxCef/pull/39#issuecomment-407337023, or mute the thread https://github.com/notifications/unsubscribe-auth/AXvRt-0xgYLg_oDzEvBT7NBk1fpiMU73ks5uJuRQgaJpZM4Reoq0 .

--

Subscribe to the Igloo newsletter http://igloovision.us6.list-manage.com/subscribe?u=f76bf4dd96af03cb03898feda&id=1a3cbff1b0.

This e-mail including any attachments is confidential and may be legally privileged. If you have received it in error please advise the sender immediately by return email and then delete it from your system. The unauthorized use, distribution, copying or alteration of this email is strictly forbidden. Email communications cannot be guaranteed to be secure or error free, therefore, Igloo Vision Ltd does not accept liability for any errors, omissions or viruses. Any opinions contained in this message are those of the author and are not given or endorsed by Igloo Vision Ltd unless the context so requires that to be the case.

*Igloo Vision Ltd *  Registered Address: Unit 2, Craven Court, Stokewood Rd, Craven Arms, Shropshire, SY7 8PF, UK Company Number:  06628206 *Igloo Vision USA, Co. *Registered address: c/o Dyke Yaxley LLC, 3700 Park East Drive, Suite 250, Cleveland,
https://maps.google.com/?q=3700+Park+East+Drive,+Suite+250,+Cleveland,+OH+44122,+USA&entry=gmail&source=gOH 44122, USA Corporation Number: 6035749 Igloo Vision Canada Inc Registered address: 375 Water St, Suite 680, Vancouver BC V6B5C6, Canada Company Number: BC1135255  Ontario Company Number: 1983760 Igloo Vision PTY Ltd Registered Address: Woodstock, 2761 Nangus Road, Nangus, NSW, 2722, Australia Company Number: 624824746             

Please consider the environment before printing this email.

rjx-ray avatar Jul 24 '18 12:07 rjx-ray

That was the problem, I hadn't switched to the right branch, thanks

rjx-ray avatar Jul 24 '18 12:07 rjx-ray