Jacob Wilkins

Results 44 issues of Jacob Wilkins

Currently no automated testing for JSONising structural formats. > At the moment, manual testing shows problems with saving the input parameters in the output files: > ``` > File "MDANSE/Framework/Jobs/IJob.py",...

Testing

As far as I can tell, CurrentSession.py is not referred to by any other file, since in the end the 'session' objects were implemented in the GUI instead. You're welcome...

enhancement
good first issue
Technical Debt

**Is your feature request related to a problem? Please describe.** Currently, there are multiple stages to a `Configurator`: - Building the `settings` dict - Accessing the `(_)configuration` dict - Building...

enhancement
Technical Debt

**Description of the error** Appears during the rework `AtomCluster` is now missing @ https://github.com/ISISNeutronMuon/MDANSE/blob/protos/MDANSE/Src/MDANSE/Framework/Jobs/RigidBodyTrajectory.py#L128 Likewise `Atom` now missing at https://github.com/ISISNeutronMuon/MDANSE/blob/protos/MDANSE/Src/MDANSE/MolecularDynamics/Trajectory.py#L1014 **Describe the expected result** N/A **Describe the actual result** Missing...

bug
enhancement

**Description of work** - Replace `SubclassFactory` with a classic `RegisterFactory` to avoid metaclass magic, allow effective ABCs and explicit inclusion (i.e. not including `Converter` as an `IJob` and thus making...

enhancement
Technical Debt

**Description of work** Complete rework of MDANSE infrastructure to replace parameter dictionaries with [`descriptor`](https://docs.python.org/3/howto/descriptor.html) `Parameter`s with validators. **Fixes** - Moves the emphasis of data validation out of the GUI -...

enhancement
Technical Debt

**Description of work** Adds button to save plot data to file. **Fixes** Fixes #765 **To test** Use save button. There are options to put `%axis%` and `%line%` to save each...

enhancement

**Description of work** Generalise sliderpack and reduce manual code for 2 sliders. **Fixes** N/A **To test** Sliderpack should work as normal.

Technical Debt

**Description of work** Refactor all the plotters to use generator constructs, gridspecs and attempt to reduce code-duplication. **Fixes** Prevent number of plots corresponding to number of datasets. **To test** Try...

Technical Debt

**Description of the error** Changing Matplotlib settings through the matplotlib buttons rather than MDANSE's panel results in the graph not matching the settings in the MDANSE penel. Changing any MDANSE...

bug
enhancement