tespy icon indicating copy to clipboard operation
tespy copied to clipboard

New Component: DiabaticCompressor

Open maltefritz opened this issue 3 years ago • 2 comments

See issue #299

maltefritz avatar Jan 10 '22 10:01 maltefritz

Hello @maltefritz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 41:80: E501 line too long (94 > 79 characters) Line 42:80: E501 line too long (81 > 79 characters) Line 43:80: E501 line too long (86 > 79 characters) Line 44:80: E501 line too long (90 > 79 characters) Line 45:80: E501 line too long (87 > 79 characters) Line 235:80: E501 line too long (83 > 79 characters)

pep8speaks avatar Jan 10 '22 10:01 pep8speaks

This pull request introduces 5 alerts when merging 68c3612c8f930c73b884214cbf810f59151d7d7e into 518fd8e2156f75022cad227909fdaa58deacf59e - view on LGTM.com

new alerts:

  • 5 for Unused import

lgtm-com[bot] avatar Jan 10 '22 10:01 lgtm-com[bot]

Is this still ongoing?

fwitte avatar Dec 03 '23 11:12 fwitte

One could implement polytropic compressor model here, for example see doi.org/10.1115/1.3239827 or https://www.turbomachinerymag.com/view/compressor-performance-and-thermodynamic.

fwitte avatar Dec 03 '23 11:12 fwitte