oemof-solph icon indicating copy to clipboard operation
oemof-solph copied to clipboard

Published 20 hours ago • verified publisher icon oemof

Rename Transformer

Open p-snft opened this issue 4 years ago • 3 comments

When people hear "transformer", they think of electrical devices. However, the GenericTransformer is neither meant to be (only) electrical nor bidirectional (as electrical transformers typically are). Thus, I got the suggestion (thx to @psychon) to rename it to GenericConverter. The term is more general and does not imply that back-conversion is possible.

p-snft avatar Oct 28 '20 12:10 p-snft

I like this idea, but also do not have much problems with "transformer".

psychon avatar Oct 28 '20 16:10 psychon

Coming from a pure engineering background and hearing "transformer" in the first examples led me to a serious confusion. I would strongly advice to rename this.

Fernando3161 avatar Dec 01 '21 14:12 Fernando3161

We should make a decision in a plenum session at https://github.com/oemof/oemof/issues/96.

p-snft avatar Dec 02 '21 12:12 p-snft