feedinlib icon indicating copy to clipboard operation
feedinlib copied to clipboard

Attempt to fix the deprecation issues...

Open GregorBecker opened this issue 3 years ago • 0 comments

... described by @uvchik in #62.

  • Since the new version of pvlib has made some changes to the data structures of the PV models, I have adapted the respective accesses to the new structure.

  • In addition, the two new parameters "module_type" and "racking_model" were added. These have to be set to the old state again on (#72)

    - module_type = "glass_glass" 
    - racking_module = "open_rack" 
    
  • The new version of pvlib also requires the direct normal irradiation (dni), which was calculated in the test file to reach the assert values again. For this purpose a zenith angle of about 75° was calculated. This seems a bit high for the first of January. Does anyone here have more detailed knowledge and can tell me what I need to change?

  • furthermore I removed the shapely deprecation in open_FRED.py.

  • Files touched: models/pvlib.py, open_FRED.py

  • Before I started my PR, the feedinlib already failed some tests on the Windpower model. This is still the case as I have not looked at the Windpowerlib.

  • After this PR the pvlib Version has to be >= 0.9.0 (dependencies)

GregorBecker avatar Jun 06 '22 08:06 GregorBecker