demandlib icon indicating copy to clipboard operation
demandlib copied to clipboard

Changed heat_building.py to include checks for non-residential shlp_type

Open ddceruti opened this issue 2 years ago • 7 comments

  • Added a ValueError to catch unwanted error downstream

Now the non residential buildings will throw a ValueError to avoid non supported integers in the database located in src/demandlib/bdew/bdew_data. This made the function heat_building.get_sigmoid_parameters return an empty list if self.shlp_type was not 0 for non-commercial buildings. Updated the documentation of the class HeatBuilding to reflect the needed input data too.

ddceruti avatar Oct 25 '23 16:10 ddceruti

Added a few more checks to the heat_building.get_sigmoid_parameters function and added .iloc[0] to avoid warnings.

ddceruti avatar Oct 25 '23 16:10 ddceruti

Added checks and slightly improved functions in src/demandlib/bdew/heat_building.py documentation and updated AUTHOR and CONTRIB files

ddceruti avatar Oct 30 '23 15:10 ddceruti

Why did you close this?

p-snft avatar Oct 31 '23 18:10 p-snft

Why did you close this?

Hi again, sorry, it was not intentional. Thanks for reopening, I checked the code and it is working.

ddceruti avatar Nov 02 '23 08:11 ddceruti

any update on this? :)

maurerle avatar Apr 15 '24 07:04 maurerle

Hi, I added the small simplifications as suggested by @p-snft . All clear from my side .

ddceruti avatar Apr 15 '24 08:04 ddceruti

Hi @maurerle I added a new commit with your improvements.

ddceruti avatar Apr 24 '24 15:04 ddceruti