explainerdashboard icon indicating copy to clipboard operation
explainerdashboard copied to clipboard

Verification of dtypes of columns of X_row* is same that self.X

Open salmuz opened this issue 1 year ago • 2 comments

Hello, I want to contribute by fixing two different bugs that are related to the usage of Ligthgbm. 

  1. NaN values in the category columns (which can cause an exception if we want to sorted(...))
       '<' not supported between instances of 'str' and 'float'
  1. Preserve the right dtypes of columns of X (dataframe) so that that Ligthm predict(..) function doesn't throw errors.

salmuz avatar Mar 25 '24 17:03 salmuz

cool, thanks! tests are passing, but please have a look at my comments and see if you can add a few test cases for this new function...

oegedijk avatar Mar 27 '24 20:03 oegedijk

Hello, I will do the requested changes as soon as possible (the next week). Thanks

salmuz avatar Mar 28 '24 14:03 salmuz