odysseas.eth

Results 83 comments of odysseas.eth

I addressed all your comments, except for the library. The parser needs the state to have a nicer UX. It also needs console2, vm, so the imports would get a...

@mds1 I like txDetail, cause we call the outer struct Transaction. It feels very intuitive.

@mds1 what's up with `projectRoot`? Locally, I have only one definition in the interface.

Thank you guys for helping me push this through the finish line. Your suggestions were really good.

wrt the tests not passing. Shouldn't solc 8.0 support struct decoding?

@mds1 -- I think that @gakonst meant that we can have Test.sol et al. at 8.0 (and the tests that inherit it) without caring that the user contract (the one...

I think that forge will automatically use the appropriate solc version? W

@mds1 would it help if we defined `pragma experimental ABIEncoderV2;`? EDIT: with the experimental flag, the whole thing compiles for 0.7.0 but not for 0.7.6 (0.7.6 seems to have issues...

@ZeroEkkusu -- so changing it back to an abstract contract - For some reason, it compiles with 0.6.0 and 0.7.0, but not with 0.7.6 🙃 - How can we use...

@ZeroEkkusu @mds1 can I get an ack on alignment for the design before going into implementation