ipwb
ipwb copied to clipboard
Add tests for URI-Rs with query strings
In #287 @ibnesayeed highlighted that the query string was stripped from a URI-R due to Flask's handling of "paths" in the server hooks.
A test ought to be written for this. Such a test would include a WARC with a URI-R containing a querying string parameter.
We cannot validate this by looking at the TimeMap in the test, as the QS will likely be canonicalized off.
@ibnesayeed Do you have a suggestion on how we can test the currently implemented functions to ensure they are handling the parameters as expected?
You can use Flask's testing framework to avoid many things you are doing using urllib and other packages like that.