Odudex
Odudex
Time to refine the PR run `poetry run poe black` to format your code changes. run `poetry run poe lint` to run pylint to check some code compliance parameters, then...
Ok, now that I merged other pull requests, this branch has some conflicts to be solved. The PR also have some changes in unrelated files. Since this PR is also...
That works too! I still see changes in .gitignore and PR templates that needs to be undone.
In my opinion, two new, smaller PRs from scratch, without overwhelming git maneuvers, and where @spatcho understand every step, is safer and more didactic. The same applies to `poetry run...
Loop talks and focus deviations are exactly what I would like to avoid. For that, I think the best strategy is to keep it simple, break things that are starting...
> so we changed that template and forgot to merge `main` into `develop` Good catch. Merged `main` into `develop`
Export to CNC feature is "abandoned", as non of devs have one to test, and, until now, we didn't know any user making use of it. I was even suggesting...
Sorry I didn't look at this issue yet, but I see you are digging deep. Yes, the QR structure was optimized, from strings of zeros, ones and `\n`, to binary...
> Does it make sense if I inspire from the [thermal printer code](https://github.com/selfcustody/krux/blob/d66f21e1ef6352a4a9bc639fd13b761add6b97db/src/krux/printers/thermal.py#L118) to understand the optimized qr_code array and adapt the cnc code ? I don't have a thermal...
> Ok, did some progress [here](https://youtu.be/7mH9H314tz0) and here You're close!