ODrive icon indicating copy to clipboard operation
ODrive copied to clipboard

Update Dockerfile with missing package for build 'debconf'.

Open SiarheiHerasiuta opened this issue 4 weeks ago • 3 comments

This additional package needed to pass container build. Please merge this small fix with master.

SiarheiHerasiuta avatar Dec 02 '25 09:12 SiarheiHerasiuta

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 02 '25 09:12 CLAassistant

What happens if debconf is omitted?

And please note that for us to be able to consider the contribution you would need to sign the Contributor License Agreement (see comment above).

samuelsadok avatar Dec 12 '25 11:12 samuelsadok

    • 'debconf' is needed to build firmware in Docker container way. So it is missing dependency. 2 - image I agree with license/cla, something wrong with github and it is not show that I am agree.

SiarheiHerasiuta avatar Dec 12 '25 12:12 SiarheiHerasiuta

  1. Can you share the error message that happens when trying to build without debconf? Sorry to be pedantic, but this is useful for documentation and future maintenance, if any.
  2. Ah all good, I can see your CLA agreement on the list. Seems to be a hickup with the CLA Assistant.

samuelsadok avatar Dec 16 '25 10:12 samuelsadok

I retest master branch today on a clear Ubuntu 16.x and find just red warning (not docker build blocking as I see before and it is strange). I provide screen for better understanding. image

SiarheiHerasiuta avatar Dec 17 '25 22:12 SiarheiHerasiuta

I see, so it looks like a false alarm? Like the red debconf message presumably made you think that debconf is missing, but upon closer inspection it's just a warning that was emitted by debconf itself. If that's the case we can close this PR.

samuelsadok avatar Dec 19 '25 07:12 samuelsadok

I also test master against 'newest' Ubuntu 20, 22 and 24 and see no debconf warning message. So yes, I agree to close pull request.

SiarheiHerasiuta avatar Dec 19 '25 10:12 SiarheiHerasiuta