ODrive icon indicating copy to clipboard operation
ODrive copied to clipboard
verified publisher icon odriverobotics

Don't move count_in_cpr without moving shadow_count

Open Wetmelon opened this issue 3 years ago • 2 comments

Wetmelon avatar Sep 26 '22 07:09 Wetmelon

I'm currently too detached from this part of the codebase to quickly judge if this change is good. Is it tested? Please also add a note to the changelog.

samuelsadok avatar Sep 26 '22 10:09 samuelsadok

It's not ready to merge (not tested). We originally added this when we were having some issues with absolute encoder async, but we ended up adding the latched value at the top of the function, so this should be redundant (but potentially troublesome).

I'm on the fence about changing it at all tbh.

Wetmelon avatar Sep 27 '22 03:09 Wetmelon