web icon indicating copy to clipboard operation
web copied to clipboard

Pick order in overview section doesn't include all heroes in some cases

Open Armin-GS opened this issue 3 years ago • 3 comments

Current Behavior Heroes that abandon (?) the game (possibly at any stage of the game) are not shown in the overview section pick order.

Expected behavior/code All heroes should be listed in the picking order section.

Additional context/Screenshots Case example: https://www.opendota.com/matches/5970577811 image Also, this might be unrelated but he randomed the hero, so maybe the problem is caused because he randomed?

Armin-GS avatar Apr 29 '21 17:04 Armin-GS

This is weird, but also shows up in the Steam Web API so it's not specific to us.

Could be the randoming though--maybe you can verify with another match where someone randomed but didn't abandon.

howardchung avatar Apr 30 '21 23:04 howardchung

Could be the randoming though--maybe you can verify with another match where someone randomed but didn't abandon.

I've checked this and seems to be the randoming that causes this issue. Since randoming can only be done in the first phase right now, can the website kinda mitigate this bug by showing the randomed hero at the beginning of the list titled "randomed" and then show the rest of the picks and their orders?

Armin-GS avatar May 01 '21 11:05 Armin-GS

probably, i think we do have data on which heroes are randomed and could put them at the front. This might change again in the future though

howardchung avatar May 01 '21 23:05 howardchung