15 players, 10 on Dire's side

[atcol]

Current Behavior I see 15 players instead of 10.

Expected behavior/code See match https://www.opendota.com/matches/4497217362

There are 5 anonymous players on Dire's side.

Console Output No output other than:

Request to access cookie or storage on “https://d33wubrfki0l68.cloudfront.net/bundles/8e50b48cebe079ce085fa76ae7cf3066777b3110.js” was blocked because we are blocking all third-party storage access requests and content blocking is enabled.

Environment

• Browser Version: Firefox 69.0.1 (64-bit)
• OS: Ubuntu Linux 19.04.

[ahi-el]

this looks to be an issue with the open api

https://api.opendota.com/api/matches/4497217362? call returns a 'players' array with 15 players for some reason. Will look into that tomorrow.

In the meantime / to avoid future bugs like this, we can filter out 'players' with null values when setting them in the store. @howardchung what do you think?

something to note - one of the anonymous players has a tome of knowledge buff

[bdbch]

@hooahest we could filter out users but in general I'd be against that since by filtering stuff out we can't find bugs like this without a big portion of luck. I think we should take the opportunity, fix this bug asap and keep the frontend the way it is.

[howardchung]

I believe this was due to a temporary bug that was fixed later, we didn't backfill the correct data.