web icon indicating copy to clipboard operation
web copied to clipboard

Add ability to manually track MMR and/or percent until next badge

Open dovchinnikov opened this issue 5 years ago • 15 comments

Is your feature request related to a problem? Please describe. Many players still track MMR with spreadsheets and it's inconvenient.

Describe the solution you'd like Add an ability to manually enter the MMR after some match so MMR changes would be displayable in the table like in old Dota interface with +/- near each match. It should not be publicly available, i.e. private use only. It could be a separate tab in place of #1843.

This is what my table looks like: image

I cannot view the match details right away unless I insert a link in each row, I have to manually copy formula to compute the delta, and no other sites has such a feature.

What do you think?

dovchinnikov avatar Oct 11 '18 10:10 dovchinnikov

As far as I know and off the top of my head, the only solution to this is with a client-side application for each person that wishes to track this information.

Sent with GitHawk

mobyte0 avatar Oct 11 '18 14:10 mobyte0

Yeah, I'm not sure how many people would use this if you had to input all the data manually. It wouldn't be much more beneficial than the spreadsheet approach, especially since we can't provide a match link either unless the user types in the match ID.

howardchung avatar Oct 12 '18 06:10 howardchung

especially since we can't provide a match link either unless the user types in the match ID

Wait, you have all the match IDs already, and I see this feature as a separate column with input fields in this view (or in the another separate tab): screen shot 2018-10-23 at 13 43 43

This data may be used to build a graph like the old one when MMR was public.

dovchinnikov avatar Oct 23 '18 20:10 dovchinnikov

The problem is that we can't link the match IDs with the changes in MMR.

howardchung avatar Nov 18 '18 00:11 howardchung

@howardchung why? Sorry, I still don't get it.

dovchinnikov avatar Nov 18 '18 15:11 dovchinnikov

Previously, we were able to check a player's current MMR at any point. Since we also know when a player finishes a game, we can just associate that MMR change with the match. However, since we can't check MMR anymore, it's not possible to link MMR with a specific match.

howardchung avatar Nov 18 '18 18:11 howardchung

we can't check MMR anymore

Because Valve closed this API, right?

dovchinnikov avatar Nov 18 '18 21:11 dovchinnikov

yes, it was removed along with introduction of medals

howardchung avatar Nov 19 '18 00:11 howardchung

That's why I came here :) Since it's not possible to get MMR via official APIs, could you please add an input field near each ranked match, so the user could manually enter new MMR?

dovchinnikov avatar Nov 19 '18 09:11 dovchinnikov

Without any data verification I'm not sure we shouldn't store this data server-side since we won't know whether it's accurate.

Maybe it could be done client side and saved in localStorage but at that point it's not much more useful than a spreadsheet anyway?

I suspect the usage of this feature would be very low since it requires significant manual effort.

howardchung avatar Nov 19 '18 09:11 howardchung

Without any data verification I'm not sure we shouldn't store this data server-side since we won't know whether it's accurate.

Yes. That's why I've proposed that it should not be publicly available.

Maybe it could be done client side and saved in localStorage but at that point it's not much more useful than a spreadsheet anyway?

It will be useful since maintaining the spreadsheet is so much work. Spreadsheet cannot automatically:

  • add a new row after match is finished, user has to add it manually after each match;
  • insert match id after match is finished, user has to manually find it in client and insert it into the spreadsheet (I've given up on match IDs in my example);
  • insert date and time (I'm adding date and ignoring the time for the sake of reducing the manual work to maintain the spreadsheet);
  • compute MMR deltas, unless user is experienced with spreadsheet functions;
  • highlight MMR deltas in green/red;
  • track solo/party (I'm doing this is a single spreadsheet and it's not quite convenient).

All of the above is already available on the site, and the only missing piece is ability to manually enter the MMR value after each match.

These values should be visible to the user only, so it would make no sense to insert whatever MMR he wants. I.e. if users wants some stats at the end of the season, then opendota gives the ability to view them. The only validation is required that the value is a number > 0 and less than something reasonable.

I have multiple accounts (who doesn't? :)), and if the user won't lose all values after re-login, then local storage is ok.

I suspect the usage of this feature would be very low since it requires significant manual effort.

I cannot comment on the usage of this feature, but I'd say it requires way less manual effort than spreadsheet approach.

dovchinnikov avatar Nov 19 '18 15:11 dovchinnikov

Chiming in here - I think it could be useful, but would clutter the screen unless there was a separate page for the analytics side of it and purely have the user type the MMR on the match page.

pacollins avatar Apr 06 '19 19:04 pacollins

I'm interested in adding support for this: now that MMR change is fixed based on match conditions, no manual effort is required beyond entering a single reference point.

It would be possible to infer back to the last MMR changes and forward at least until another major MMR update (potentially beyond depending on the update).

One open question in my mind is, should this be private or public? Perhaps up to the user? The main reason for being private is that a player could easily just lie about their reference point, so this isn't necessarily "useful" data to others. On the flip-side, I can imagine wanting to share progress with friends. So perhaps it defaults to private, but an be made public?

Without having dug into the internals of the old page yet, it's not entirely clear to me if this should be in it's own separate view, or can reuse the old one.

Please let me know if you have thoughts!

ndeakin avatar Apr 24 '20 03:04 ndeakin

We can start with it public and then add restrictions on it as needed. I think it's fine as long we label the data clearly as self-reported.

On the server-side the changes are:

  • New table to store self-reported MMR
  • new POST API endpoint to accept MMR inputs
  • add self-reported MMR to an existing endpoint or or existing endpoints
  • add task to insert match workflow to update MMR values after ranked matches

Once we have the data we can think about how to display it. I guess we're interested both in a "current" MMR value and in MMR values after each match played (history?)

howardchung avatar Apr 27 '20 10:04 howardchung

Thanks for the overview of the server side changes needed, and sounds good about leaving it public with statement that it's user-reported. I'll start looking into the details and may bug you in the discord.

Regarding current vs history, it's definitely accurate to say that my goal is to show current and history - the history is the big motivation for me personally, since the number alone is easy enough to grab in client. History on the other hand isn't really tracked or shown anywhere any longer to my knowledge.

ndeakin avatar Apr 29 '20 00:04 ndeakin