web icon indicating copy to clipboard operation
web copied to clipboard

Page is too wide for browser

Open albertcui opened this issue 7 years ago • 9 comments

Current Behavior Match content overflows side of screen image

Environment ChromeOS Version 66.0.3359.158 (Official Build) (64-bit)

Possible Solution

Min width is set as 1200px which seems to be too large.

albertcui avatar Jun 04 '18 00:06 albertcui

https://www.opendota.com/matches/3931500559/vision

Note: at 533px the page transitions to mobile layout, maybe we need to do that earlier (at 1200px?)

howardchung avatar Jun 04 '18 01:06 howardchung

Actually does this affect all tabs? What is your screen resolution?

howardchung avatar Jun 04 '18 01:06 howardchung

Yes, this affects all tabs. You can see the match header is messed up.

Resolution is 1200 x 800.

I think the problem is that we have a min width at all?

albertcui avatar Jun 04 '18 01:06 albertcui

Could try removing it. I don't remember why it was added originally. That said, I think the content will not fit in less than 1200 pixels, so it might not do anything.

howardchung avatar Jun 04 '18 05:06 howardchung

It can also be a bug related to the size of the div with the min-div. I'll try to fix it, thanks for the info guys!

HenriqueFadoni avatar Jan 27 '19 20:01 HenriqueFadoni

I've found the bug, and I fixed it. However, I cannot find the divs to apply the css

HenriqueFadoni avatar Jan 27 '19 20:01 HenriqueFadoni

image

HenriqueFadoni avatar Jan 27 '19 20:01 HenriqueFadoni

Never mind, I fixed it, I'll do the PR

HenriqueFadoni avatar Jan 27 '19 21:01 HenriqueFadoni

Can someone approve my pull request? It already passed the tests, I just need a reviewer with write access.

HenriqueFadoni avatar Jan 27 '19 21:01 HenriqueFadoni