web icon indicating copy to clipboard operation
web copied to clipboard

Page number should be added to URL as query string.

Open jojo-tutor opened this issue 7 years ago • 3 comments

In this link: https://www.opendota.com/teams/2163/matches, on the "Matches" and "Heroes" Tab, there are pagination, if you should go to other pages, you must add the current page to the URL, so that whenever the user will refresh the browser/share the URL, the current page will retain accordingly. This is a good practice. And also, in pagination, it's good to have an option like: results per page.

opendota

jojo-tutor avatar Feb 15 '18 01:02 jojo-tutor

Yes, I think we can definitely add a page parameter that's bound to the PaginatedTable component and saves the state in the URL

howardchung avatar Feb 15 '18 06:02 howardchung

Hey, I'll pick this up. I still need to set up the OD environment; will work on this issue over course of week

ghost avatar Feb 26 '18 02:02 ghost

The problem with using the page number in the url when sorting descending is it gets out of date very quickly. You may be trying to share a link for a match on page 2, but tomorrow the match has been pushed down to page 3.

Is this a common use case that you want to support? If so, it's probably better to store something that can generate the same page list each time, for example the topmost match id.

coreymaher avatar Mar 26 '18 06:03 coreymaher