web
web copied to clipboard
odota
deaths in match story are not correct for bot matches
Hello, I noticed that the match story is not showing deaths correctly, in this match I played as QOP I died only one time (17/1/24), but when reading the story I end up dying 11 times.
match story: https://www.opendota.com/matches/3612364883/story
even in this match story: https://www.opendota.com/matches/3587190357/story I was the tinker, and I never died the entire match ( 30/0/9) but the story indicated that I died 6 times.
also this: https://www.opendota.com/matches/3614400968/story I was the storm, I died 2 times (10/2/12), but the story said I died 6 times.
Interesting, @mdiller do you know why this is happening?
It looks like for some reason the teamfights objects are indicating that QOP died in every teamfight.
I think the issue lies in odota/core , but we would need a replay file where this happens to fix it. They all have expired.
@rezk2ll if you have a match where this happened and the replay has not expired, that would help us debug the issue.
here: https://www.opendota.com/matches/3665097967/story visage KDA 17/0/30, died in story 9 times huskar too, 31/2/18, died in story 7 times
the match was On Sunday, January 7, 2018.
Huh, weird. It looks like an issue with the parser that creates the teamfight objects. If you look in the teamfights tab of the 3665097967, you can see that in the second teamfight, it says visage died.
(Meaning yeah I agree the issue lies in odota/core)
I found the issue. This only occurs in Bot matches and it happens because the Bots always get mapped to player_slots 128...132 regardless of in which team they are.
Also related https://github.com/odota/web/issues/532
Oh yeah, I didn't notice it was a bot match.
I don't think there was a quick fix for this so that's why the issue is still open. Probably it can be worked around by having special logic if the lobby type is co-op bot