upgrade-util icon indicating copy to clipboard operation
upgrade-util copied to clipboard

[FIX] modules: consider unknown modules uninstalled

Open jjmaksoud opened this issue 1 month ago • 6 comments

The function force_install_module could be called before the discovery of new modules. The validation for the module itself is deferred so we could also be lenient with the dependency module validation. case of l10n_es_edi_verifactu, is a relatively recent module that is missing in some origin dbs coming from some saas versions, we can consider it uninstalled.

jjmaksoud avatar Nov 25 '25 08:11 jjmaksoud

Pull request status dashboard

robodoo avatar Nov 25 '25 08:11 robodoo

upgradeci retry with always only bas l10n_es_edi_verifactu

jjmaksoud avatar Nov 25 '25 08:11 jjmaksoud

There is something odd here... the module should exists in the target version. Thus is should be in the DB info :/

aj-fuentes avatar Nov 25 '25 09:11 aj-fuentes

There is something odd here... the module should exists in the target version. Thus is should be in the DB info :/

Hello, I litterrally had the error fixed by this PR this morning during LabOdoo upgrade, if you want I can provide the 17.0 dump. Module added in 17, remove in 17.1 added back in 18.0 from what I see

GaetanVandenBergh avatar Nov 25 '25 10:11 GaetanVandenBergh

The problem is the if_installed, that's not the same flow as the actual module to install. The module to install check is delayed, not the if_installed so we need this patch. This comes to mind.

aj-fuentes avatar Nov 25 '25 10:11 aj-fuentes

upgradeci retry with always only base l10n_es_edi_verifactu

aj-fuentes avatar Nov 25 '25 13:11 aj-fuentes