[FIX] util/models: Fix UpgradeError

[sagu-odoo]

if model is remove but related to that data is still in upgrade_test_data so it failing because here in expected getting the records of that model which is removed and in value we are not getting values of which model is removed that is why below mentioned traceback is rasied for fixing it cleaning up the data from value in upgrade_test_data

Traceback (most recent call last):
  File "/home/odoo/src/odoo/11.0/odoo/service/server.py", line 1054, in preload_registries
    registry = Registry.new(dbname, update_module=update_module)
  File "/home/odoo/src/odoo/11.0/odoo/modules/registry.py", line 85, in new
    odoo.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/home/odoo/src/odoo/11.0/odoo/modules/loading.py", line 391, in load_modules
    migrations.migrate_module(package, 'end')
  File "/home/odoo/src/odoo/11.0/odoo/modules/migration.py", line 202, in migrate_module
    migrate(self.cr, installed_version)
  File "/home/odoo/src/odoo/11.0/odoo/addons/base/maintenance/migrations/base/0.0.0/end-moved0.py", line 19, in migrate
    % "\n".join("\t- %s.%s" % m for m in sorted(moved_fields))
odoo.addons.base.maintenance.migrations.util.exceptions.UpgradeError: New `moved0` field. It happen when the ORM cannot change a column type by itself.

upg-2797343 opw-4800416

[robodoo]

[aj-fuentes]

Isn't it simpler to just switch if value != expected: to if value and value != expected:?

[sagu-odoo]

Isn't it simpler to just switch if value != expected: to if value and value != expected:?

value = [['test','value1'],['test2','value2']] expected = [['test','value1'],['test2','value2']]

test2 model is removed

then expected = [['test','value1'],['test2','value2']] value = [['test','value1']]

For this i have handled this way

Edit: correct me if I am missing something

[aj-fuentes]

Then switch: https://github.com/odoo/upgrade-util/blob/e6f36d0d5f3c42453876b046d3d6a2ba39403a40/src/base/0.0.0/end-moved0.py#L13-L16 into

    expected = {tuple(i) for i in cr.fetchone()[0]} if cr.rowcount else set()
    moved_fields = [r for r in pre.get_moved0_columns(cr) if r not in expected]
    if moved_fields:

In other words as long as the moved columns are a subset of the expected (aka originally existing columns) values we are good.

[sagu-odoo]

Thanks for your review. I thought as the data will effect during model removal that is why I opt to fix it there in remove_model. this will be good as we are not using anywhere upgrade_test_data for key "base.tests.test_moved0.TestMoved0" .