upgrade-util icon indicating copy to clipboard operation
upgrade-util copied to clipboard

Published 20 hours ago • verified publisher icon odoo

[REF] util.views: refactor converter code, regroup views helpers

Open andreabak opened this issue 1 year ago • 6 comments

Overview of changes (see commits for details):

  • refactored BootstrapConverter code, separating conversion code and operations from bootstrap-specific code. This way other kind of converters can be implemented, reusing pre-defined ElementOperations into lists (eg. ReplaceClasses/RenameAttributes/etc.)
    • this will also be useful in the (near) future to consolidate into util similar helpers in PS custom-util, commonly used to quickly fix studio and COW views (without all the manual lxml operations boilerplate)
  • generalized helpers and moved from odoo/upgrade base/16.0/pre-90-convert-bootstrap5.py so that they can be reused for other similar kind of operations using converters (ie. apply converter to all html fields / templates, etc.) (upgrade PR: odoo/upgrade#5431 )
  • re-organized views-related helpers into a subpackage util.views (converter, bootstrap, records)
  • misc fixes and tweaks

andreabak avatar Dec 12 '23 10:12 andreabak

Pull request status dashboard.

robodoo avatar Dec 12 '23 10:12 robodoo

upgradeci retry with always all modules in all versions

andreabak avatar Dec 12 '23 14:12 andreabak

upgradeci skip

KangOl avatar Feb 26 '24 16:02 KangOl

upgradeci retry with always only base mass_mailing point_of_sale test_themes theme_common theme_treehouse web web_editor website website_blog website_enterprise website_event website_mass_mailing website_sale in all versions

KangOl avatar Mar 05 '24 14:03 KangOl

upgradeci retry

andreabak avatar Mar 11 '24 12:03 andreabak

@KangOl I've rebased this on the latest master commit, resolved conflicts, etc.. CI checks seem good. Is it ready to go? (together with https://github.com/odoo/upgrade/pull/5431)

FYI @aj-fuentes

andreabak avatar May 15 '24 13:05 andreabak