odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] mail: add illustration to call permissions dialog

Open edi-odoo opened this issue 1 month ago • 5 comments

This PR adds an illustration to the permissions dialog when microphone and camera need to be activated in the browser's permissions settings.

LightScreenshot 2025-12-03 at 12 06 19
DarkScreenshot 2025-12-03 at 12 11 28

task-5265099


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

edi-odoo avatar Nov 25 '25 13:11 edi-odoo

Pull request status dashboard

robodoo avatar Nov 25 '25 13:11 robodoo

LGTM Just wonder if you intend to put some colors to make it look better? Like here's an example

Image

Hi @alexkuhn , thanks for your feedback. No we don't intend to add more color. We don't use colors anywhere else in Odoo's backend so we're sticking to the current style. If this were to change we could indeed think about it. Also we don't want the illustration to have more importance than the rest (this is also why we placed it next to the text instead of having it above and bigger).

edi-odoo avatar Dec 12 '25 09:12 edi-odoo

@edi-odoo The lack of color requires more visual effort, because the image with white fill and black stroke on the lady uses same colors as the text (text is black on white background, illustration is black stroke on white fill).

We could reduce saturation or use much more neutral color, and/or use a monochrome filter so that the fills are just shade of a single color.

alexkuhn avatar Dec 12 '25 10:12 alexkuhn

Here are example from google meet. You see they use a few colors and this is actually helpful to recognize the illustration with less effort, while still allowing text to shine: Screenshot 2025-12-12 at 11 56 09 Screenshot 2025-12-12 at 11 56 18

alexkuhn avatar Dec 12 '25 10:12 alexkuhn

Here are example from google meet. You see they use a few colors and this is actually helpful to recognize the illustration with less effort, while still allowing text to shine: Screenshot 2025-12-12 at 11 56 09 Screenshot 2025-12-12 at 11 56 18

Scratch what I said before, I just noticed a mistake in the svg (in dark mode she's lost her nose!) I'll make the changes for that and while I'm at it I'll add a little bit of color :)

edi-odoo avatar Dec 12 '25 14:12 edi-odoo