odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FW][FIX] point_of_sale: prevent double confirmation of dialog

Open fw-bot opened this issue 6 months ago • 12 comments

For the TextInputPopup component a feature was introduced in 2f5c5c15644412cfb6493c661b2f1b927c8cc7e2 that allows the user to confirm the popup by simply clicking enter.

The problem is that the dialog itself has a hotkey on "CTRL+Enter" that will also confirm the popup.

This means that if a user uses the "CTRL+Enter" hotkey, the popup will be confirmed twice.

Steps to reproduce:

  1. In restaurant, click the button to add a new floor
  2. Write a name for the floor
  3. Click "CTRL+Enter"
  4. Observe that 2 floors with the given name were created instead of one.

The fix: We stop the propagation of the event

Task: 4698289


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#212134

fw-bot avatar May 30 '25 17:05 fw-bot

Pull request status dashboard

robodoo avatar May 30 '25 17:05 robodoo

This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot avatar May 30 '25 17:05 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Jun 08 '25 02:06 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Jun 15 '25 02:06 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Jun 22 '25 02:06 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Jun 28 '25 02:06 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Jul 26 '25 02:07 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Aug 23 '25 02:08 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Sep 20 '25 02:09 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Oct 18 '25 02:10 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Nov 15 '25 02:11 fw-bot

@vlst-odoo this forward port of odoo/odoo#212134 is awaiting action (not merged or closed).

fw-bot avatar Dec 13 '25 02:12 fw-bot