odoo
[IMP] product,uom: remove uom category and merge packaging into uom
WIP
Task-4252043
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
very quick comments since it's still a wip (why is it ready for review then?)
@Feyensv we marked it as ready for review because fp requested to merge it for the freeze (i.e. tomorrow) this past Friday after everyone basically left for the day :skull:
Ooooh, we love this kind of last minute notices, even more when the office is empty for holidays :rofl: Well, I guess the testing (and most of the reviews) will be for another year then ^^' I'll take a deeper look today then, good luck with the quick review and merge :people_hugging:
Looks like fp has been overruled, this no longer has to be merged tomorrow :partying_face: just asap instead, so review from all teams for their touched code is still appreciated :pray:
I am creating a product in kg, but I put my product.supplierinfo (purchase vendor info) with a pack of 6, then when I do a purchase order of 2, my total to receive is 0.01 kg. (on runbot it was 0.12, but pack of 6 was referring to cm) How are we supposed to link arbitary UoMs with each other? The packaging qty on the stock move was 1.67.
@jco-odoo I asked a similar question twice on this PR, as well as directly to FP and MGM. No one replied, except FP with an answer that doesn't satisfy me the slightest.
@william-andre It is because you have not understood: e.g. when you have a pack of tiles of 4 kg which compose 1 m², you create a new kg uom which is 0.25 m² if the uom of your product is in kg. You can however put any UoM in there and if there is no link to be found between the UoMs it probably just does something with the factor. If you expect as a user that you can edit the quantities afterwards (which you think you can as you can put any uom anywhere), this is utterly confusing, but I guess that is the fire in your picture. You should not be able to add UoMs that are not referenced. (or have references but not to you)
Merge method set to rebase and merge, using the PR as merge commit message.
@mohammadhossam @amoyaux linked pull request(s) odoo/enterprise#72206 not ready. Linked PRs are not staged until all of them are ready.
@mohammadhossam @amoyaux May I ask why is the "uom_ids" field implemented on the sales tab section of the product form view, while it influences both the usability of packaging on SO and PO as well?
This makes it super confusing form user perspective - configuration happens under sales but it impacts PO. Further more, you have basically removed the option of which packagings are used for purchase and which for sales, which was possible under the old workflow.
Is this something that could still be improved before this hits V19?
