odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FIX] l10n_sa_invoice: Fixed Labels and Translations

Open alny-odoo opened this issue 1 year ago • 5 comments

Description of the issue/feature this PR addresses: Link to task: #4218972 This change fixes english and arabic labels & translations in the l10n_sa_invoice module

Current behavior before PR: Some labels are inaccurate or do not match the saudi arabia ZATCA invoice template.

Desired behavior after PR is merged: Labels are more accurate and match the saudi arabia ZATCA invoice template.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

alny-odoo avatar Oct 17 '24 08:10 alny-odoo

Pull request status dashboard

robodoo avatar Oct 17 '24 08:10 robodoo

Hi @jco-odoo This is a fix for the l10n_sa invoice labels. Task: https://www.odoo.com/web#model=project.task&id=4218972

alny-odoo avatar Oct 17 '24 08:10 alny-odoo

@alny-odoo In 15 still, really? On itself, not a problem for me, but you will have all the fw-ports.

You are also sure we want to do this only for SA and not for GCC @ygu-odoo

jco-odoo avatar Oct 17 '24 13:10 jco-odoo

@ygu-odoo It is not a problem to do it in 15.0, but 15 is unsupported and it is a bit odd that Dubai does all the new features in the oldest versions.

jco-odoo avatar Oct 17 '24 14:10 jco-odoo

@jco-odoo we will check the relation with the GCC module

cc: @alny-odoo

ygu-odoo avatar Oct 17 '24 16:10 ygu-odoo

@jco-odoo , I checked with @mebe-odoo and he agreed that we should make these changes in l10n_sa only.

@alny-odoo is making another change on this. I will let you know once this is ready for another review. Thank you

ygu-odoo avatar Oct 23 '24 08:10 ygu-odoo

@jco-odoo , there is 1 quick fix left after which the PR will be ready for your review. @khfa-odoo will let you know once he has pushed it today. Thank you

cc: @akr-odoo

ygu-odoo avatar Oct 30 '24 19:10 ygu-odoo

Hello @jco-odoo, the PR is ready

khfa-odoo avatar Oct 31 '24 06:10 khfa-odoo

@robodoo r+

jco-odoo avatar Nov 01 '24 00:11 jco-odoo

@robodoo r-

jco-odoo avatar Nov 01 '24 00:11 jco-odoo

@khfa-odoo Please let me know if the table is really necessary.

jco-odoo avatar Nov 01 '24 00:11 jco-odoo

@robodoo r+

jco-odoo avatar Nov 01 '24 08:11 jco-odoo