odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FW][FIX] hw_drivers: disable extensions in chromium

Open fw-bot opened this issue 1 year ago • 4 comments

In the new IoT image we use Chromium instead of Firefox, however it comes bundled with some extensions, namely uBlock, which use up disk space in the background. This leads to the /tmp directory getting full, which causes various errors and instability.

After this change, the /tmp directory only reaches around 50% capacity, even after many restarts and webpage visits.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#182883

fw-bot avatar Oct 09 '24 13:10 fw-bot

Pull request status dashboard

robodoo avatar Oct 09 '24 13:10 robodoo

This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot avatar Oct 09 '24 13:10 fw-bot

@maxthewhale @qle-odoo ci/runbot failed on this forward-port PR

fw-bot avatar Oct 09 '24 13:10 fw-bot

@MaxTheWhale Just a quick note about handling Chromium correctly in the display driver: Currently Chromium is exited forcefully every time which also gives popups ("Restore Pages"). Though you can ignore this by using the browser argument --hide-crash-restore-bubble instead you can also safely close Chromium down using the SIGTERM signal. So use: subprocess.run(['pkill', '-15', self.browser.split('-')[0]], check=False) More info: https://askubuntu.com/a/1065246

danielboven avatar Oct 09 '24 15:10 danielboven

@MaxTheWhale Just a quick note about handling Chromium correctly in the display driver: Currently Chromium is exited forcefully every time which also gives popups ("Restore Pages"). Though you can ignore this by using the browser argument --hide-crash-restore-bubble instead you can also safely close Chromium down using the SIGTERM signal. So use: subprocess.run(['pkill', '-15', self.browser.split('-')[0]], check=False) More info: https://askubuntu.com/a/1065246

Thanks for the info Daniel! I'll implement that in a new PR

MaxTheWhale avatar Oct 10 '24 07:10 MaxTheWhale

@maxthewhale @qle-odoo this PR was modified / updated and has become a normal PR. It must be merged directly.

fw-bot avatar Oct 10 '24 07:10 fw-bot

@robodoo r+

qle-odoo avatar Oct 11 '24 07:10 qle-odoo