odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FW][FIX] website_sale: ensure delivery page is displayed in checkout

Open fw-bot opened this issue 1 year ago • 3 comments

Version: saas-17.4

Issue: When only one delivery method is available, the checkout process skips the delivery page and redirects directly to payment, which confuses users.

Fix: Removed the redundant can_skip_delivery_step logic.

  • Updated shop_checkout to always go through the delivery step if the order has deliverable products.
  • Now checking order_sudo._has_deliverable_products() to determine if delivery selection is needed.
  • Orders with non-deliverable products skip the delivery step and go directly to payment.

The delivery page will now be displayed regardless of the number of delivery methods, improving user experience by allowing them to review their delivery details before payment.

Forward-Port-Of: odoo/odoo#182269

fw-bot avatar Oct 09 '24 12:10 fw-bot

Pull request status dashboard

robodoo avatar Oct 09 '24 12:10 robodoo

This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot avatar Oct 09 '24 12:10 fw-bot

@rupa-odoo @AntoineVDV ci/runbot failed on this forward-port PR

fw-bot avatar Oct 09 '24 13:10 fw-bot

@rupa-odoo @AntoineVDV this PR was modified / updated and has become a normal PR. It must be merged directly.

fw-bot avatar Oct 10 '24 05:10 fw-bot

@rupa-odoo @AntoineVDV this forward port of odoo/odoo#182269 is awaiting action (not merged or closed).

fw-bot avatar Oct 13 '24 02:10 fw-bot

@rupa-odoo @AntoineVDV this forward port of odoo/odoo#182269 is awaiting action (not merged or closed).

fw-bot avatar Oct 14 '24 02:10 fw-bot

@rupa-odoo @AntoineVDV this forward port of odoo/odoo#182269 is awaiting action (not merged or closed).

fw-bot avatar Oct 15 '24 02:10 fw-bot

@robodoo r+

rupa-odoo avatar Oct 15 '24 04:10 rupa-odoo

@rupa-odoo @AntoineVDV linked pull request(s) odoo/enterprise#71618 not ready. Linked PRs are not staged until all of them are ready.

robodoo avatar Oct 15 '24 05:10 robodoo